From 103d630d80009bcf59167bcb9163d532032572c7 Mon Sep 17 00:00:00 2001
From: Wojtek Figat <wojtek@figat.pl>
Date: Sun, 7 Feb 2021 21:41:17 +0100
Subject: [PATCH] Fix tooltips generation for native properties to reflect
 getter and setter docsa

---
 Source/Engine/Level/Actor.h                   |  8 ++++----
 .../Bindings/BindingsGenerator.CSharp.cs      | 20 +++----------------
 .../Bindings/BindingsGenerator.Parsing.cs     |  7 +++++++
 3 files changed, 14 insertions(+), 21 deletions(-)

diff --git a/Source/Engine/Level/Actor.h b/Source/Engine/Level/Actor.h
index 334021c28..7621e4a2a 100644
--- a/Source/Engine/Level/Actor.h
+++ b/Source/Engine/Level/Actor.h
@@ -437,13 +437,13 @@ public:
     }
 
     /// <summary>
-    /// Sets actor orientation in 3D space
+    /// Sets actor orientation in 3D space.
     /// </summary>
     /// <param name="value">The value to set.</param>
     API_PROPERTY() void SetOrientation(const Quaternion& value);
 
     /// <summary>
-    /// Gets actor scale in 3D space
+    /// Gets actor scale in 3D space.
     /// </summary>
     API_PROPERTY(Attributes="HideInEditor, NoSerialize")
     FORCE_INLINE Vector3 GetScale() const
@@ -458,13 +458,13 @@ public:
     API_PROPERTY() void SetScale(const Vector3& value);
 
     /// <summary>
-    /// Gets actor rotation matrix
+    /// Gets actor rotation matrix.
     /// </summary>
     API_PROPERTY(Attributes="HideInEditor, NoSerialize")
     Matrix GetRotation() const;
 
     /// <summary>
-    /// Sets actor rotation matrix
+    /// Sets actor rotation matrix.
     /// </summary>
     /// <param name="value">The value to set.</param>
     API_PROPERTY() void SetRotation(const Matrix& value);
diff --git a/Source/Tools/Flax.Build/Bindings/BindingsGenerator.CSharp.cs b/Source/Tools/Flax.Build/Bindings/BindingsGenerator.CSharp.cs
index d51d7b754..15d8825a8 100644
--- a/Source/Tools/Flax.Build/Bindings/BindingsGenerator.CSharp.cs
+++ b/Source/Tools/Flax.Build/Bindings/BindingsGenerator.CSharp.cs
@@ -488,10 +488,7 @@ namespace Flax.Build.Bindings
                 {
                     if (comment.Contains("/// <returns>"))
                         continue;
-                    var c = comment.Replace("::", ".");
-                    contents.Append(indent);
-                    contents.Append(c);
-                    contents.AppendLine();
+                    contents.Append(indent).Append(comment.Replace("::", ".")).AppendLine();
                 }
 
                 GenerateCSharpAttributes(buildData, contents, indent, eventInfo, true);
@@ -586,11 +583,7 @@ namespace Flax.Build.Bindings
                 {
                     if (comment.Contains("/// <returns>"))
                         continue;
-
-                    var c = comment.Replace("::", ".");
-                    contents.Append(indent);
-                    contents.Append(c);
-                    contents.AppendLine();
+                    contents.Append(indent).Append(comment.Replace("::", ".")).AppendLine();
                 }
 
                 GenerateCSharpAttributes(buildData, contents, indent, fieldInfo, true);
@@ -636,14 +629,7 @@ namespace Flax.Build.Bindings
                 {
                     if (comment.Contains("/// <returns>") || comment.Contains("<param name="))
                         continue;
-
-                    var c = comment.Replace("::", ".");
-                    contents.Append(indent);
-                    if (propertyInfo.Getter != null && propertyInfo.Setter != null)
-                        contents.Append(c.Replace("/// Gets ", "/// Gets or sets "));
-                    else
-                        contents.Append(c);
-                    contents.AppendLine();
+                    contents.Append(indent).Append(comment.Replace("::", ".")).AppendLine();
                 }
 
                 GenerateCSharpAttributes(buildData, contents, indent, propertyInfo, true);
diff --git a/Source/Tools/Flax.Build/Bindings/BindingsGenerator.Parsing.cs b/Source/Tools/Flax.Build/Bindings/BindingsGenerator.Parsing.cs
index 42c0e73b2..a7d6782d1 100644
--- a/Source/Tools/Flax.Build/Bindings/BindingsGenerator.Parsing.cs
+++ b/Source/Tools/Flax.Build/Bindings/BindingsGenerator.Parsing.cs
@@ -711,6 +711,13 @@ namespace Flax.Build.Bindings
                         return propertyInfo;
                     throw new Exception($"Property {propertyName} in class {classInfo.Name} (line {context.Tokenizer.CurrentLine}) has mismatching getter return type ({getterType}) and setter parameter type ({setterType}). Both getter and setter methods must use the same value type used for property.");
                 }
+
+                // Fix documentation comment to reflect both getter and setters available
+                for (var i = 0; i < propertyInfo.Comment.Length; i++)
+                {
+                    ref var comment = ref propertyInfo.Comment[i];
+                    comment = comment.Replace("/// Gets ", "/// Gets or sets ");
+                }
             }
 
             return propertyInfo;