From 15028c60ba7f5e19745fa054008c9274972aefe6 Mon Sep 17 00:00:00 2001 From: Damian Korczowski Date: Sun, 21 Feb 2021 14:44:16 +0100 Subject: [PATCH] Remove GetDefaultPageSize Duplicate. We already have the API for this: `Platform::GetCPUInfo().PageSize`. --- Source/Engine/Platform/Base/PlatformBase.h | 5 ----- Source/Engine/Platform/Unix/UnixPlatform.cpp | 5 ----- Source/Engine/Platform/Unix/UnixPlatform.h | 1 - Source/Engine/Platform/Win32/Win32Platform.cpp | 9 --------- Source/Engine/Platform/Win32/Win32Platform.h | 1 - 5 files changed, 21 deletions(-) diff --git a/Source/Engine/Platform/Base/PlatformBase.h b/Source/Engine/Platform/Base/PlatformBase.h index 7c200172d..d640eb252 100644 --- a/Source/Engine/Platform/Base/PlatformBase.h +++ b/Source/Engine/Platform/Base/PlatformBase.h @@ -316,11 +316,6 @@ public: /// A pointer to the memory block to deallocate. static void Free(void* ptr) = delete; - /// - /// Returns the OS's default page size that can be used with AllocatePages. - /// - static uint64 GetDefaultPageSize() = delete; - /// /// Allocates pages memory block. /// diff --git a/Source/Engine/Platform/Unix/UnixPlatform.cpp b/Source/Engine/Platform/Unix/UnixPlatform.cpp index 6255e3588..8cda61cc8 100644 --- a/Source/Engine/Platform/Unix/UnixPlatform.cpp +++ b/Source/Engine/Platform/Unix/UnixPlatform.cpp @@ -51,11 +51,6 @@ void UnixPlatform::Free(void* ptr) } } -uint64 Win32Platform::GetDefaultPageSize() -{ - return 16; -} - void* Win32Platform::AllocatePages(uint64 numPages, uint64 pageSize) { const uint64 numBytes = numPages * pageSize; diff --git a/Source/Engine/Platform/Unix/UnixPlatform.h b/Source/Engine/Platform/Unix/UnixPlatform.h index 9996e3d7e..12d4e5bc2 100644 --- a/Source/Engine/Platform/Unix/UnixPlatform.h +++ b/Source/Engine/Platform/Unix/UnixPlatform.h @@ -16,7 +16,6 @@ public: // [PlatformBase] static void* Allocate(uint64 size, uint64 alignment); static void Free(void* ptr); - static uint64 GetDefaultPageSize(); static void* AllocatePages(uint64 numPages, uint64 pageSize); static void FreePages(void* ptr); static uint64 GetCurrentProcessId(); diff --git a/Source/Engine/Platform/Win32/Win32Platform.cpp b/Source/Engine/Platform/Win32/Win32Platform.cpp index 39d52a64c..06c9e542b 100644 --- a/Source/Engine/Platform/Win32/Win32Platform.cpp +++ b/Source/Engine/Platform/Win32/Win32Platform.cpp @@ -298,15 +298,6 @@ void Win32Platform::AtomicStore(int64 volatile* dst, int64 value) InterlockedExchange64(dst, value); } -uint64 Win32Platform::GetDefaultPageSize() -{ - SYSTEM_INFO systemInfo; - GetSystemInfo(&systemInfo); - - // Return the page size obtained from system - return systemInfo.dwPageSize; -} - void* Win32Platform::AllocatePages(uint64 numPages, uint64 pageSize) { const uint64 numBytes = numPages * pageSize; diff --git a/Source/Engine/Platform/Win32/Win32Platform.h b/Source/Engine/Platform/Win32/Win32Platform.h index a1930fad8..ffb1d1d87 100644 --- a/Source/Engine/Platform/Win32/Win32Platform.h +++ b/Source/Engine/Platform/Win32/Win32Platform.h @@ -43,7 +43,6 @@ public: { _aligned_free(ptr); } - static uint64 GetDefaultPageSize(); static void* AllocatePages(uint64 numPages, uint64 pageSize); static void FreePages(void* ptr); static bool Is64BitPlatform();