GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused transient param from profile events

Browse Source
This commit is contained in:
Wojtek Figat
2021-05-13 12:04:10 +02:00
parent 389eee22e3
commit 32806e8f4e
2 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Engine/Profiler/ProfilerCPU.cpp
View File

@@ -154,7 +154,7 @@ int32 ProfilerCPU::BeginEvent()
return thread->BeginEvent(); return thread->BeginEvent();
} }
int32 ProfilerCPU::BeginEvent(const Char* name, bool transient) int32 ProfilerCPU::BeginEvent(const Char* name)
{ {
if (!Enabled) if (!Enabled)
return -1; return -1;
@@ -165,7 +165,7 @@ int32 ProfilerCPU::BeginEvent(const Char* name, bool transient)
auto src = name; auto src = name;
if (src) if (src)
{ {
auto end = dst + ARRAY_COUNT(e.Name) - 1; const auto end = dst + ARRAY_COUNT(e.Name) - 1;
while (*src && dst != end) while (*src && dst != end)
*dst++ = *src++; *dst++ = *src++;
} }
@@ -173,7 +173,7 @@ int32 ProfilerCPU::BeginEvent(const Char* name, bool transient)
return index; return index;
} }
int32 ProfilerCPU::BeginEvent(const char* name, bool transient) int32 ProfilerCPU::BeginEvent(const char* name)
{ {
if (!Enabled) if (!Enabled)
return -1; return -1;
@@ -184,7 +184,7 @@ int32 ProfilerCPU::BeginEvent(const char* name, bool transient)
auto src = name; auto src = name;
if (src) if (src)
{ {
auto end = dst + ARRAY_COUNT(e.Name) - 1; const auto end = dst + ARRAY_COUNT(e.Name) - 1;
while (*src && dst != end) while (*src && dst != end)
*dst++ = *src++; *dst++ = *src++;
} }

18
Source/Engine/Profiler/ProfilerCPU.h
View File

@@ -325,17 +325,15 @@ public:
/// Begins the event. Call EndEvent with index parameter equal to the returned value by BeginEvent function. /// Begins the event. Call EndEvent with index parameter equal to the returned value by BeginEvent function.
/// </summary> /// </summary>
/// <param name="name">The event name.</param> /// <param name="name">The event name.</param>
/// <param name="transient">True if name is transient and should be cached by allocator (not static).</param>
/// <returns>The event token.</returns> /// <returns>The event token.</returns>
static int32 BeginEvent(const Char* name, bool transient = false); static int32 BeginEvent(const Char* name);
/// <summary> /// <summary>
/// Begins the event. Call EndEvent with index parameter equal to the returned value by BeginEvent function. /// Begins the event. Call EndEvent with index parameter equal to the returned value by BeginEvent function.
/// </summary> /// </summary>
/// <param name="name">The event name.</param> /// <param name="name">The event name.</param>
/// <param name="transient">True if name is transient and should be cached by allocator (not static).</param>
/// <returns>The event token.</returns> /// <returns>The event token.</returns>
static int32 BeginEvent(const char* name, bool transient = false); static int32 BeginEvent(const char* name);
/// <summary> /// <summary>
/// Ends the event. /// Ends the event.
@@ -356,14 +354,14 @@ struct ScopeProfileBlockCPU
{ {
int32 Index; int32 Index;
FORCE_INLINE ScopeProfileBlockCPU(const Char* name, bool transient = false) FORCE_INLINE ScopeProfileBlockCPU(const Char* name)
{ {
Index = ProfilerCPU::BeginEvent(name, transient); Index = ProfilerCPU::BeginEvent(name);
} }
FORCE_INLINE ScopeProfileBlockCPU(const char* name, bool transient = false) FORCE_INLINE ScopeProfileBlockCPU(const char* name)
{ {
Index = ProfilerCPU::BeginEvent(name, transient); Index = ProfilerCPU::BeginEvent(name);
} }
FORCE_INLINE ~ScopeProfileBlockCPU() FORCE_INLINE ~ScopeProfileBlockCPU()
@@ -381,12 +379,12 @@ struct TIsPODType<ProfilerCPU::Event>
// Shortcut macros for profiling a single code block execution on CPU // Shortcut macros for profiling a single code block execution on CPU
// Use ZoneTransient for Tracy for code that can be hot-reloaded (eg. in Editor) or if name can be a variable // Use ZoneTransient for Tracy for code that can be hot-reloaded (eg. in Editor) or if name can be a variable
#define PROFILE_CPU_NAMED(name) ZoneTransientN(___tracy_scoped_zone, name, true); ScopeProfileBlockCPU ProfileBlockCPU(name, true) #define PROFILE_CPU_NAMED(name) ZoneTransientN(___tracy_scoped_zone, name, true); ScopeProfileBlockCPU ProfileBlockCPU(name)
#if defined(_MSC_VER) #if defined(_MSC_VER)
#if USE_EDITOR #if USE_EDITOR
#define PROFILE_CPU() ZoneTransient(___tracy_scoped_zone, true); ScopeProfileBlockCPU ProfileBlockCPU(TEXT(__FUNCTION__), false) #define PROFILE_CPU() ZoneTransient(___tracy_scoped_zone, true); ScopeProfileBlockCPU ProfileBlockCPU(TEXT(__FUNCTION__))
#else #else
#define PROFILE_CPU() ZoneNamed(___tracy_scoped_zone, true); ScopeProfileBlockCPU ProfileBlockCPU(TEXT(__FUNCTION__)) #define PROFILE_CPU() ZoneNamed(___tracy_scoped_zone, true); ScopeProfileBlockCPU ProfileBlockCPU(TEXT(__FUNCTION__))