Format code and simplify IControlReference a little bit

#3123

Source/Editor/CustomEditors/Editors/ControlReferenceEditor.cs

@@ -1,6 +1,6 @@
-using System;
+// Copyright (c) 2012-2024 Wojciech Figat. All rights reserved.
-using System.Collections.Generic;
+
-using FlaxEditor.CustomEditors;
+using System;
 using FlaxEditor.CustomEditors.Elements;
 using FlaxEditor.GUI;
 using FlaxEditor.GUI.Drag;
@@ -116,7 +116,6 @@ public class UIControlRefPickerControl : Control
     public UIControlRefPickerControl()
     : base(0, 0, 50, 16)
     {
-        
     }
 
     private void OnValueChanged()
@@ -485,7 +484,7 @@ public class ControlReferenceEditor : CustomEditor
                     Type t = typeof(ControlReference<>);
                     Type tw = t.MakeGenericType(new Type[] { genericType });
                     var instance = Activator.CreateInstance(tw);
-                    (instance as IControlReference).Set(_element.CustomControl.Value);
+                    ((IControlReference)instance).UIControl = _element.CustomControl.Value;
                     SetValue(instance);
                 }
             };

Source/Engine/UI/ControlReference.cs

@@ -1,58 +1,36 @@
-using System;
+// Copyright (c) 2012-2024 Wojciech Figat. All rights reserved.
-using System.Collections.Generic;
+
-using FlaxEngine;
+using System;
 using FlaxEngine.GUI;
 
 namespace FlaxEngine;
 
 /// <summary>
-/// The control reference interface.
+/// Interface for control references access.
 /// </summary>
 public interface IControlReference
 {
     /// <summary>
-    /// The UIControl.
+    /// Gets or sets the reference to <see cref="FlaxEngine.UIControl"/> actor.
     /// </summary>
-    public UIControl UIControl { get; }
+    public UIControl UIControl { get; set; }
 
     /// <summary>
-    /// The Control type
+    /// Gets the type of the control the interface uses.
     /// </summary>
-    /// <returns>The Control Type</returns>
+    public Type ControlType { get; }
-    public Type GetControlType();
-    
-    /// <summary>
-    /// A safe set of the UI Control. Will warn if Control is of the wrong type.
-    /// </summary>
-    /// <param name="uiControl">The UIControl to set.</param>
-    public void Set(UIControl uiControl);
 }
 
 /// <summary>
-/// ControlReference class.
+/// UI Control reference utility. References UI Control actor with a typed control type.
 /// </summary>
 [Serializable]
 public struct ControlReference<T> : IControlReference where T : Control
 {
-    [Serialize, ShowInEditor]
     private UIControl _uiControl;
 
     /// <summary>
-    /// Default constructor for ControlReference;
+    /// Gets the typed UI control object owned by the referenced <see cref="FlaxEngine.UIControl"/> actor.
-    /// </summary>
-    public ControlReference()
-    {
-        _uiControl = null;
-    }
-
-    /// <inheritdoc />
-    public Type GetControlType()
-    {
-        return typeof(T);
-    }
-
-    /// <summary>
-    /// The Control attached to the UI Control.
     /// </summary>
     [HideInEditor]
     public T Control
@@ -61,39 +39,34 @@ public struct ControlReference<T> : IControlReference where T : Control
         {
             if (_uiControl != null && _uiControl.Control is T t)
                 return t;
-            else
-            {
             Debug.Write(LogType.Warning, "Trying to get Control from ControlReference but UIControl is null, or UIControl.Control is null, or UIControl.Control is not the correct type.");
             return null;
         }
     }
-    }
 
     /// <inheritdoc />
-    public UIControl UIControl => _uiControl;
+    public UIControl UIControl
-
-    /// <inheritdoc />
-    public void Set(UIControl uiControl)
     {
-        if (uiControl == null)
+        get => _uiControl;
+        set
         {
-            Clear();
+            if (value == null)
-            return;
-        }
-        
-        if (uiControl.Control is T castedControl)
-            _uiControl = uiControl;
-        else
-            Debug.Write(LogType.Warning, "Trying to set ControlReference but UIControl.Control is null or UIControl.Control is not the correct type.");
-    }
-
-    /// <summary>
-    /// Clears the UIControl reference.
-    /// </summary>
-    public void Clear()
             {
                 _uiControl = null;
             }
+            else if (value.Control is T t)
+            {
+                _uiControl = value;
+            }
+            else
+            {
+                Debug.Write(LogType.Warning, "Trying to set ControlReference but UIControl.Control is null or UIControl.Control is not the correct type.");
+            }
+        }
+    }
+
+    /// <inheritdoc />
+    public Type ControlType => typeof(T);
 
     /// <summary>
     /// The implicit operator for the Control.