GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Add feedback from PVS (static code analyzer)

Browse Source 
https://pvs-studio.com/en/blog/posts/cpp/1153/
This commit is contained in:
Wojtek Figat
2024-08-15 13:01:40 +02:00
parent 0b03a5da0d
commit 45e83d6d15
9 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Editor/Content/Items/AssetItem.cs
View File

@@ -80,7 +80,7 @@ namespace FlaxEditor.Content
// Translate asset type name
var typeName = TypeName;
string[] typeNamespaces = typeName.Split('.');
if (typeNamespaces.Length != 0 && typeNamespaces.Length != 0)
if (typeNamespaces.Length != 0 && typeNamespaces[typeNamespaces.Length - 1].Length != 0)
{
typeName = Utilities.Utils.GetPropertyNameUI(typeNamespaces[typeNamespaces.Length - 1]);
}

2
Source/Editor/GUI/Dialogs/Dialog.cs
View File

@@ -22,7 +22,7 @@ namespace FlaxEditor.GUI.Dialogs
/// <summary>
/// The parent window.
/// </summary>
protected Window _window;
protected volatile Window _window;
/// <summary>
/// The dialog result.

2
Source/Editor/Surface/VisjectSurface.Input.cs
View File

@@ -492,7 +492,7 @@ namespace FlaxEditor.Surface
Focus();
return true;
}
if (_rightMouseDown || (_middleMouseDown && _middleMouseDown))
if (_rightMouseDown || _middleMouseDown)
{
// Start navigating
StartMouseCapture();

2
Source/Editor/Utilities/MemberComparison.cs
View File

@@ -79,7 +79,7 @@ namespace FlaxEditor.Utilities
value = Convert.ToInt32(value);
else if (type.Type == typeof(long))
value = Convert.ToInt64(value);
else if (type.Type == typeof(int))
else if (type.Type == typeof(ushort))
value = Convert.ToUInt16(value);
else if (type.Type == typeof(uint))
value = Convert.ToUInt32(value);