From 48c6339ebbbcb699a457c7ba5a3b87b9c8df03ba Mon Sep 17 00:00:00 2001
From: Wojtek Figat <wojtek@figat.pl>
Date: Fri, 4 Jul 2025 12:21:25 +0200
Subject: [PATCH] Fix memory leak on material instances when updating layout of
 Text Render

---
 Source/Engine/UI/TextRender.cpp | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/Source/Engine/UI/TextRender.cpp b/Source/Engine/UI/TextRender.cpp
index 951da2316..6b2988b7a 100644
--- a/Source/Engine/UI/TextRender.cpp
+++ b/Source/Engine/UI/TextRender.cpp
@@ -190,6 +190,10 @@ void TextRender::UpdateLayout()
     _buffersDirty = true;
 
     // Init draw chunks data
+    Array<MaterialInstance*, InlinedAllocation<8>> materials;
+    materials.Resize(_drawChunks.Count());
+    for (int32 i = 0; i < materials.Count(); i++)
+        materials[i] = _drawChunks[i].Material;
     DrawChunk drawChunk;
     drawChunk.Actor = this;
     drawChunk.StartIndex = 0;
@@ -242,10 +246,12 @@ void TextRender::UpdateLayout()
                     }
 
                     // Setup material
-                    drawChunk.Material = Content::CreateVirtualAsset<MaterialInstance>();
+                    if (_drawChunks.Count() < materials.Count())
+                        drawChunk.Material = materials[_drawChunks.Count()];
+                    else
+                        drawChunk.Material = Content::CreateVirtualAsset<MaterialInstance>();
                     drawChunk.Material->SetBaseMaterial(Material.Get());
-                    for (auto& param : drawChunk.Material->Params)
-                        param.SetIsOverride(false);
+                    drawChunk.Material->ResetParameters();
 
                     // Set the font parameter
                     static StringView FontParamName = TEXT("Font");