GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak for Mono image refs

Browse Source
This commit is contained in:
Wojtek Figat
2021-03-14 23:57:37 +01:00
parent 1d575f51b6
commit 76e056698b
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Engine/Scripting/ManagedCLR/MAssembly.Mono.cpp
View File

@@ -123,7 +123,6 @@ void MAssembly::Unload(bool isReloading)
LOG(Info, "Unloading managed assembly \'{0}\' (is reloading)", String(_name)); LOG(Info, "Unloading managed assembly \'{0}\' (is reloading)", String(_name));
mono_assembly_close(_monoAssembly); mono_assembly_close(_monoAssembly);
mono_image_close(_monoImage);
} }
else else
{ {
@@ -306,11 +305,9 @@ bool MAssembly::LoadWithImage(const String& assemblyPath)
// Setup assembly // Setup assembly
const auto assembly = mono_assembly_load_from_full(assemblyImage, name.Substring(0, name.Length() - 3).Get(), &status, false); const auto assembly = mono_assembly_load_from_full(assemblyImage, name.Substring(0, name.Length() - 3).Get(), &status, false);
mono_image_close(assemblyImage);
if (status != MONO_IMAGE_OK || assembly == nullptr) if (status != MONO_IMAGE_OK || assembly == nullptr)
{ {
// Close image if error occurred
mono_image_close(assemblyImage);
Log::CLRInnerException(TEXT("Mono assembly image is corrupted at ") + assemblyPath); Log::CLRInnerException(TEXT("Mono assembly image is corrupted at ") + assemblyPath);
return true; return true;
} }