GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Fix RunProcess not working in development builds

Browse Source 
Works around a possible compiler bug caused by db6aab1cf6
This commit is contained in:
Ari Vuollet
2022-12-04 18:09:07 +02:00
parent a0a087fc91
commit 7eae439624
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Engine/Platform/Windows/WindowsPlatform.cpp
View File

@@ -1079,7 +1079,6 @@ int32 WindowsPlatform::RunProcess(const StringView& cmdLine, const StringView& w
HANDLE stdOutRead = nullptr; HANDLE stdOutRead = nullptr;
HANDLE stdErrRead = nullptr; HANDLE stdErrRead = nullptr;
Array<byte> attributeList;
if (captureStdOut) if (captureStdOut)
{ {
@@ -1101,8 +1100,7 @@ int32 WindowsPlatform::RunProcess(const StringView& cmdLine, const StringView& w
SIZE_T bufferSize = 0; SIZE_T bufferSize = 0;
if (!InitializeProcThreadAttributeList(nullptr, 1, 0, &bufferSize) && GetLastError() == ERROR_INSUFFICIENT_BUFFER) if (!InitializeProcThreadAttributeList(nullptr, 1, 0, &bufferSize) && GetLastError() == ERROR_INSUFFICIENT_BUFFER)
{ {
attributeList.Resize((int32)bufferSize); startupInfoEx.lpAttributeList = (LPPROC_THREAD_ATTRIBUTE_LIST)Allocate(sizeof(byte) * bufferSize, 16);
startupInfoEx.lpAttributeList = (LPPROC_THREAD_ATTRIBUTE_LIST)attributeList.Get();
if (!InitializeProcThreadAttributeList(startupInfoEx.lpAttributeList, 1, 0, &bufferSize)) if (!InitializeProcThreadAttributeList(startupInfoEx.lpAttributeList, 1, 0, &bufferSize))
{ {
LOG(Warning, "InitializeProcThreadAttributeList failed"); LOG(Warning, "InitializeProcThreadAttributeList failed");
@@ -1176,6 +1174,7 @@ ERROR_EXIT:
if (startupInfoEx.lpAttributeList != nullptr) if (startupInfoEx.lpAttributeList != nullptr)
{ {
DeleteProcThreadAttributeList(startupInfoEx.lpAttributeList); DeleteProcThreadAttributeList(startupInfoEx.lpAttributeList);
Allocator::Free(startupInfoEx.lpAttributeList);
} }
return result; return result;