GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clean code

Browse Source
This commit is contained in:
Ruan Lucas
2023-07-19 16:28:15 -04:00
parent 7855db951e
commit 8a9b76a468
1 changed files with 38 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

80
Source/Editor/CustomEditors/Dedicated/SplineEditor.cs
View File

@@ -154,11 +154,7 @@ namespace FlaxEditor.CustomEditors.Dedicated
private void SmoothIfNotAligned(Spline spline, int index)
{
var keyframe = spline.GetSplineKeyframe(index);
var angle = Vector3.Dot(keyframe.TangentIn.Translation.Normalized, keyframe.TangentOut.Translation.Normalized);
var isAligned = angle <= -0.99f;
if (!isAligned)
if (!IsAlignedTangentMode(spline, index))
{
SetPointSmooth(spline, index);
}
@@ -342,43 +338,6 @@ namespace FlaxEditor.CustomEditors.Dedicated
_currentTangentMode.OnSetMode(SelectedSpline, _lastPointSelected.Index);
}
private bool IsFreeTangentMode(Spline spline, int index)
{
if (IsLinearTangentMode(spline, index) || IsAlignedTangentMode(spline, index))
{
return false;
}
return true;
}
private bool IsLinearTangentMode(Spline spline, int index)
{
var keyframe = spline.GetSplineKeyframe(index);
return keyframe.TangentIn.Translation.Length == 0 && keyframe.TangentOut.Translation.Length == 0;
}
private bool IsAlignedTangentMode(Spline spline, int index)
{
var keyframe = spline.GetSplineKeyframe(index);
var tangentIn = keyframe.TangentIn.Translation;
var tangentOut = keyframe.TangentOut.Translation;
if (tangentIn.Length == 0 || tangentOut.Length == 0)
{
return false;
}
var angleBetweenTwoTangents = Vector3.Dot(tangentIn.Normalized,tangentOut.Normalized);
if (angleBetweenTwoTangents < -0.99f)
{
return true;
}
return false;
}
private void UpdateSelectedPoint()
{
// works only if select one spline
@@ -484,5 +443,42 @@ namespace FlaxEditor.CustomEditors.Dedicated
}
}
}
private static bool IsFreeTangentMode(Spline spline, int index)
{
if (IsLinearTangentMode(spline, index) || IsAlignedTangentMode(spline, index))
{
return false;
}
return true;
}
private static bool IsLinearTangentMode(Spline spline, int index)
{
var keyframe = spline.GetSplineKeyframe(index);
return keyframe.TangentIn.Translation.Length == 0 && keyframe.TangentOut.Translation.Length == 0;
}
private static bool IsAlignedTangentMode(Spline spline, int index)
{
var keyframe = spline.GetSplineKeyframe(index);
var tangentIn = keyframe.TangentIn.Translation;
var tangentOut = keyframe.TangentOut.Translation;
if (tangentIn.Length == 0 || tangentOut.Length == 0)
{
return false;
}
var angleBetweenTwoTangents = Vector3.Dot(tangentIn.Normalized, tangentOut.Normalized);
if (angleBetweenTwoTangents < -0.99f)
{
return true;
}
return false;
}
}
}