From 91cf85c50e901c23148e50491e6e2ef0e45d1aeb Mon Sep 17 00:00:00 2001 From: Wojtek Figat Date: Thu, 8 Jul 2021 19:56:34 +0200 Subject: [PATCH] Remove unused `DictionaryInitialSize` from `MAssemblyOptions` --- .../Scripting/ManagedCLR/MAssembly.Mono.cpp | 2 -- .../Scripting/ManagedCLR/MAssemblyOptions.h | 23 +------------------ 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/Source/Engine/Scripting/ManagedCLR/MAssembly.Mono.cpp b/Source/Engine/Scripting/ManagedCLR/MAssembly.Mono.cpp index 4d6c0c5ec..d73dc8a47 100644 --- a/Source/Engine/Scripting/ManagedCLR/MAssembly.Mono.cpp +++ b/Source/Engine/Scripting/ManagedCLR/MAssembly.Mono.cpp @@ -376,8 +376,6 @@ void MAssembly::OnLoading() Loading(this); _isLoading = true; - if (_classes.Capacity() == 0) - _classes.EnsureCapacity(_options.DictionaryInitialSize); // Pick a domain if (_domain == nullptr) diff --git a/Source/Engine/Scripting/ManagedCLR/MAssemblyOptions.h b/Source/Engine/Scripting/ManagedCLR/MAssemblyOptions.h index 27ae891a0..6a2579815 100644 --- a/Source/Engine/Scripting/ManagedCLR/MAssemblyOptions.h +++ b/Source/Engine/Scripting/ManagedCLR/MAssemblyOptions.h @@ -9,8 +9,6 @@ /// struct MAssemblyOptions { -public: - /// /// Should assembly cache classes on Load method. /// @@ -21,33 +19,14 @@ public: /// int32 KeepManagedFileLocked : 1; - /// - /// Initial dictionary size (prevents memory partition for bigger assemblies). - /// - int32 DictionaryInitialSize; - -public: - - /// - /// Initializes a new instance of the struct. - /// - MAssemblyOptions() - : PreCacheOnLoad(true) - , KeepManagedFileLocked(false) - , DictionaryInitialSize(1024) - { - } - /// /// Initializes a new instance of the struct. /// /// if set to true to precache assembly metadata on load. /// if set to true keep managed file locked after load. - /// Initial size of the dictionary for the classes and metadata. - MAssemblyOptions(bool preCacheOnLoad, bool keepManagedFileLocked = false, int32 dictionaryInitialSize = 1024) + MAssemblyOptions(bool preCacheOnLoad = true, bool keepManagedFileLocked = false) : PreCacheOnLoad(preCacheOnLoad) , KeepManagedFileLocked(keepManagedFileLocked) - , DictionaryInitialSize(dictionaryInitialSize) { } };