From 5cc3e409025246917e6f4a8988f1acd64526fba5 Mon Sep 17 00:00:00 2001
From: Red Kitsune <krakers114pl@gmail.com>
Date: Sun, 17 Sep 2023 20:28:34 +0200
Subject: [PATCH 1/4] Implemented better missing script handling

---
 Source/Engine/Level/Components/DummyScript.h | 67 ++++++++++++++++++++
 Source/Engine/Level/SceneObjectsFactory.cpp  |  3 +
 2 files changed, 70 insertions(+)
 create mode 100644 Source/Engine/Level/Components/DummyScript.h

diff --git a/Source/Engine/Level/Components/DummyScript.h b/Source/Engine/Level/Components/DummyScript.h
new file mode 100644
index 000000000..380648f5a
--- /dev/null
+++ b/Source/Engine/Level/Components/DummyScript.h
@@ -0,0 +1,67 @@
+#pragma once
+
+#include "Engine/Core/Cache.h"
+#include "Engine/Scripting/Script.h"
+#include "Engine/Scripting/ScriptingObjectReference.h"
+#include "Engine/Serialization/JsonWriters.h"
+
+API_CLASS(Attributes="HideInEditor") class FLAXENGINE_API DummyScript : public Script
+{
+    API_AUTO_SERIALIZATION();
+    DECLARE_SCRIPTING_TYPE(DummyScript);
+
+public:
+    API_PROPERTY(Attributes="ReadOnly")
+    FORCE_INLINE String GetMissingTypeName() const
+    {
+        if(Data.IsEmpty()) return TEXT("");
+        
+        rapidjson_flax::Document doc;
+        doc.Parse(Data.ToStringAnsi().GetText());
+        
+        String str (doc["TypeName"].GetString());
+        
+        return str;
+    }
+    
+    API_PROPERTY()
+    void SetMissingTypeName(String value)
+    {
+        _missingTypeName = value;
+    }
+    
+    API_FIELD(Hidden, Attributes="HideInEditor") String Data;
+    
+    API_PROPERTY()
+    FORCE_INLINE ScriptingObjectReference<Script> GetReferenceScript() const
+    {
+        return _referenceScript;
+    }
+    
+    API_PROPERTY()
+    void SetReferenceScript(ScriptingObjectReference<Script> value)
+    {
+        _referenceScript = value;
+
+        if(Data.IsEmpty()) return;
+        
+        MapToReferenceScript();
+    }
+
+private:
+    ScriptingObjectReference<Script> _referenceScript;
+    String _missingTypeName;
+    
+    void MapToReferenceScript()
+    {
+        rapidjson_flax::Document doc;
+        doc.Parse(Data.ToStringAnsi().GetText());
+        
+        auto modifier = Cache::ISerializeModifier.Get();
+        _referenceScript->Deserialize(doc, modifier.Value);
+
+        this->DeleteObject();
+    }
+};
+
+inline DummyScript::DummyScript(const SpawnParams& params) : Script(params){}
diff --git a/Source/Engine/Level/SceneObjectsFactory.cpp b/Source/Engine/Level/SceneObjectsFactory.cpp
index f8193c257..13321a88f 100644
--- a/Source/Engine/Level/SceneObjectsFactory.cpp
+++ b/Source/Engine/Level/SceneObjectsFactory.cpp
@@ -1,6 +1,7 @@
 // Copyright (c) 2012-2023 Wojciech Figat. All rights reserved.
 
 #include "SceneObjectsFactory.h"
+#include "Components/DummyScript.h"
 #include "Engine/Level/Actor.h"
 #include "Engine/Level/Prefabs/Prefab.h"
 #include "Engine/Content/Content.h"
@@ -238,6 +239,8 @@ void SceneObjectsFactory::HandleObjectDeserializationError(const ISerializable::
     {
         const Guid parentId = JsonTools::GetGuid(parentIdMember->value);
         Actor* parent = Scripting::FindObject<Actor>(parentId);
+        DummyScript* dummyScript = parent->AddScript<DummyScript>();
+        dummyScript->Data = String(buffer.GetString());
         if (parent)
         {
             LOG(Warning, "Parent actor of the missing object: {0}", parent->GetName());

From 7c0546c68d8653e06ad3f64ac875bac6c8020a4e Mon Sep 17 00:00:00 2001
From: Red Kitsune <krakers114pl@gmail.com>
Date: Tue, 19 Sep 2023 00:21:56 +0200
Subject: [PATCH 2/4] After CR changes

---
 .../{DummyScript.h => MissingScript.h}        | 25 +++----------------
 Source/Engine/Level/SceneObjectsFactory.cpp   | 10 +++++---
 2 files changed, 11 insertions(+), 24 deletions(-)
 rename Source/Engine/Level/Components/{DummyScript.h => MissingScript.h} (60%)

diff --git a/Source/Engine/Level/Components/DummyScript.h b/Source/Engine/Level/Components/MissingScript.h
similarity index 60%
rename from Source/Engine/Level/Components/DummyScript.h
rename to Source/Engine/Level/Components/MissingScript.h
index 380648f5a..641f905eb 100644
--- a/Source/Engine/Level/Components/DummyScript.h
+++ b/Source/Engine/Level/Components/MissingScript.h
@@ -5,30 +5,14 @@
 #include "Engine/Scripting/ScriptingObjectReference.h"
 #include "Engine/Serialization/JsonWriters.h"
 
-API_CLASS(Attributes="HideInEditor") class FLAXENGINE_API DummyScript : public Script
+API_CLASS(Attributes="HideInEditor") class FLAXENGINE_API MissingScript : public Script
 {
     API_AUTO_SERIALIZATION();
-    DECLARE_SCRIPTING_TYPE(DummyScript);
+    DECLARE_SCRIPTING_TYPE(MissingScript);
 
 public:
-    API_PROPERTY(Attributes="ReadOnly")
-    FORCE_INLINE String GetMissingTypeName() const
-    {
-        if(Data.IsEmpty()) return TEXT("");
-        
-        rapidjson_flax::Document doc;
-        doc.Parse(Data.ToStringAnsi().GetText());
-        
-        String str (doc["TypeName"].GetString());
-        
-        return str;
-    }
     
-    API_PROPERTY()
-    void SetMissingTypeName(String value)
-    {
-        _missingTypeName = value;
-    }
+    API_FIELD(Attributes="ReadOnly") String MissingTypeName;
     
     API_FIELD(Hidden, Attributes="HideInEditor") String Data;
     
@@ -50,7 +34,6 @@ public:
 
 private:
     ScriptingObjectReference<Script> _referenceScript;
-    String _missingTypeName;
     
     void MapToReferenceScript()
     {
@@ -64,4 +47,4 @@ private:
     }
 };
 
-inline DummyScript::DummyScript(const SpawnParams& params) : Script(params){}
+inline MissingScript::MissingScript(const SpawnParams& params) : Script(params){}
diff --git a/Source/Engine/Level/SceneObjectsFactory.cpp b/Source/Engine/Level/SceneObjectsFactory.cpp
index 13321a88f..2eb341a2f 100644
--- a/Source/Engine/Level/SceneObjectsFactory.cpp
+++ b/Source/Engine/Level/SceneObjectsFactory.cpp
@@ -1,7 +1,7 @@
 // Copyright (c) 2012-2023 Wojciech Figat. All rights reserved.
 
 #include "SceneObjectsFactory.h"
-#include "Components/DummyScript.h"
+#include "Components/MissingScript.h"
 #include "Engine/Level/Actor.h"
 #include "Engine/Level/Prefabs/Prefab.h"
 #include "Engine/Content/Content.h"
@@ -239,10 +239,14 @@ void SceneObjectsFactory::HandleObjectDeserializationError(const ISerializable::
     {
         const Guid parentId = JsonTools::GetGuid(parentIdMember->value);
         Actor* parent = Scripting::FindObject<Actor>(parentId);
-        DummyScript* dummyScript = parent->AddScript<DummyScript>();
-        dummyScript->Data = String(buffer.GetString());
         if (parent)
         {
+            MissingScript* dummyScript = parent->AddScript<MissingScript>();
+
+            const auto parentIdMember = value.FindMember("TypeName");
+            dummyScript->MissingTypeName = parentIdMember->value.GetString();
+            dummyScript->Data = String(buffer.GetString());
+            
             LOG(Warning, "Parent actor of the missing object: {0}", parent->GetName());
         }
     }

From 74acc93c0cf23e4109f86e03c3efabe1db88fc10 Mon Sep 17 00:00:00 2001
From: Red Kitsune <krakers114pl@gmail.com>
Date: Thu, 21 Sep 2023 01:03:35 +0200
Subject: [PATCH 3/4] Add XML comments

---
 .../Engine/Level/Components/MissingScript.h   | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/Source/Engine/Level/Components/MissingScript.h b/Source/Engine/Level/Components/MissingScript.h
index 641f905eb..601346203 100644
--- a/Source/Engine/Level/Components/MissingScript.h
+++ b/Source/Engine/Level/Components/MissingScript.h
@@ -5,23 +5,38 @@
 #include "Engine/Scripting/ScriptingObjectReference.h"
 #include "Engine/Serialization/JsonWriters.h"
 
+/// <summary>
+/// Actor script component that represents missing script.
+/// </summary>
 API_CLASS(Attributes="HideInEditor") class FLAXENGINE_API MissingScript : public Script
 {
     API_AUTO_SERIALIZATION();
     DECLARE_SCRIPTING_TYPE(MissingScript);
 
 public:
-    
+
+    /// <summary>
+    /// Namespace and type name of missing script.
+    /// </summary>
     API_FIELD(Attributes="ReadOnly") String MissingTypeName;
-    
+
+    /// <summary>
+    /// Missing script serialized data.
+    /// </summary>
     API_FIELD(Hidden, Attributes="HideInEditor") String Data;
-    
+
+    /// <summary>
+    /// Field for assigning new script to transfer data to.
+    /// </summary>
     API_PROPERTY()
     FORCE_INLINE ScriptingObjectReference<Script> GetReferenceScript() const
     {
         return _referenceScript;
     }
-    
+
+    /// <summary>
+    /// Field for assigning new script to transfer data to.
+    /// </summary>
     API_PROPERTY()
     void SetReferenceScript(ScriptingObjectReference<Script> value)
     {

From 794ccd42ff88df1f6eb12a07fb3c1003367d2646 Mon Sep 17 00:00:00 2001
From: Red Kitsune <krakers114pl@gmail.com>
Date: Thu, 21 Sep 2023 22:00:20 +0200
Subject: [PATCH 4/4] - Added MissingScriptEditor

---
 .../Dedicated/MissingScriptEditor.cs          | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Source/Editor/CustomEditors/Dedicated/MissingScriptEditor.cs

diff --git a/Source/Editor/CustomEditors/Dedicated/MissingScriptEditor.cs b/Source/Editor/CustomEditors/Dedicated/MissingScriptEditor.cs
new file mode 100644
index 000000000..03d5ddd55
--- /dev/null
+++ b/Source/Editor/CustomEditors/Dedicated/MissingScriptEditor.cs
@@ -0,0 +1,26 @@
+using FlaxEditor.CustomEditors.Editors;
+using FlaxEngine;
+using FlaxEngine.GUI;
+
+namespace FlaxEditor.CustomEditors.Dedicated;
+
+/// <summary>
+/// The missing script editor.
+/// </summary>
+[CustomEditor(typeof(MissingScript)), DefaultEditor]
+public class MissingScriptEditor : GenericEditor
+{
+    /// <inheritdoc />
+    public override void Initialize(LayoutElementsContainer layout)
+    {
+        if (layout.ContainerControl is not DropPanel dropPanel)
+        {
+            base.Initialize(layout);
+            return;
+        }
+
+        dropPanel.HeaderTextColor = Color.OrangeRed;
+        
+        base.Initialize(layout);
+    }
+}