GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix off-by-one in collection range check

Browse Source 
The check failed randomly after script reloading an dissued the following error:

```
00:19:37.789 ]: [Error] Exception has been thrown during Window.OnDraw.
Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
[ 00:19:37.805 ]: [Warning] Exception has been thrown during Window.OnUpdate. Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
Stack strace:
   at FlaxEditor.GUI.Tabs.Tabs.get_SelectedTab() in /home/me/Flax/FlaxEngine/Source/Editor/GUI/Tabs/Tabs.cs:line 242
```
This commit is contained in:
nothingTVatYT
2024-02-07 02:01:39 +01:00
committed by GitHub
parent 169024ae47
commit a9259b20a4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Editor/GUI/Tabs/Tabs.cs
View File

@@ -239,7 +239,7 @@ namespace FlaxEditor.GUI.Tabs
/// </summary> /// </summary>
public Tab SelectedTab public Tab SelectedTab
{ {
get => _selectedIndex < 0 || Children.Count <= _selectedIndex ? null : Children[_selectedIndex + 1] as Tab; get => _selectedIndex < 0 || Children.Count <= (_selectedIndex+1) ? null : Children[_selectedIndex + 1] as Tab;
set => SelectedTabIndex = value != null ? Children.IndexOf(value) - 1 : -1; set => SelectedTabIndex = value != null ? Children.IndexOf(value) - 1 : -1;
} }