GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize MCore::Array::GetAddress usage in MUtils

Browse Source
This commit is contained in:
Wojtek Figat
2023-03-29 10:39:20 +02:00
parent 94e7531109
commit bb27f85951
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Engine/Scripting/ManagedCLR/MUtils.cpp
View File

@@ -657,16 +657,18 @@ MObject* MUtils::BoxVariant(const Variant& value)
if (elementClass->IsEnum()) if (elementClass->IsEnum())
{ {
// Array of Enums // Array of Enums
byte* managedPtr = (byte*)MCore::Array::GetAddress(managed);
for (int32 i = 0; i < array.Count(); i++) for (int32 i = 0; i < array.Count(); i++)
{ {
auto data = (uint64)array[i]; auto data = (uint64)array[i];
Platform::MemoryCopy((byte*)MCore::Array::GetAddress(managed) + elementSize * i, &data, elementSize); Platform::MemoryCopy(managedPtr + elementSize * i, &data, elementSize);
} }
} }
else if (elementClass->IsValueType()) else if (elementClass->IsValueType())
{ {
// Array of Structures // Array of Structures
const VariantType elementType = UnboxVariantType(elementClass->GetType()); const VariantType elementType = UnboxVariantType(elementClass->GetType());
byte* managedPtr = (byte*)MCore::Array::GetAddress(managed);
switch (elementType.Type) switch (elementType.Type)
{ {
case VariantType::Bool: case VariantType::Bool:
@@ -697,7 +699,7 @@ MObject* MUtils::BoxVariant(const Variant& value)
#endif #endif
// Optimized boxing of raw data type // Optimized boxing of raw data type
for (int32 i = 0; i < array.Count(); i++) for (int32 i = 0; i < array.Count(); i++)
Platform::MemoryCopy((byte*)MCore::Array::GetAddress(managed) + elementSize * i, &array[i].AsData, elementSize); Platform::MemoryCopy(managedPtr + elementSize * i, &array[i].AsData, elementSize);
break; break;
case VariantType::Transform: case VariantType::Transform:
case VariantType::Matrix: case VariantType::Matrix:
@@ -709,7 +711,7 @@ MObject* MUtils::BoxVariant(const Variant& value)
#endif #endif
// Optimized boxing of raw data type // Optimized boxing of raw data type
for (int32 i = 0; i < array.Count(); i++) for (int32 i = 0; i < array.Count(); i++)
Platform::MemoryCopy((byte*)MCore::Array::GetAddress(managed) + elementSize * i, array[i].AsBlob.Data, elementSize); Platform::MemoryCopy(managedPtr + elementSize * i, array[i].AsBlob.Data, elementSize);
break; break;
case VariantType::Structure: case VariantType::Structure:
if (typeHandle) if (typeHandle)
@@ -720,7 +722,7 @@ MObject* MUtils::BoxVariant(const Variant& value)
{ {
// TODO: optimize structures boxing to not return MObject* but use raw managed object to prevent additional boxing here // TODO: optimize structures boxing to not return MObject* but use raw managed object to prevent additional boxing here
MObject* boxed = type.Struct.Box(array[i].AsBlob.Data); MObject* boxed = type.Struct.Box(array[i].AsBlob.Data);
Platform::MemoryCopy((byte*)MCore::Array::GetAddress(managed) + elementSize * i, MCore::Object::Unbox(boxed), elementSize); Platform::MemoryCopy(managedPtr + elementSize * i, MCore::Object::Unbox(boxed), elementSize);
} }
break; break;
} }