From 5d8403be5bf7848dbd764c278397bcf2fa4bfd5a Mon Sep 17 00:00:00 2001 From: Chandler Cox Date: Wed, 19 Oct 2022 20:59:55 -0500 Subject: [PATCH 1/2] moved UpdateCameraPreview call to on selection changed and on state change --- Source/Editor/Windows/EditGameWindow.cs | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/Source/Editor/Windows/EditGameWindow.cs b/Source/Editor/Windows/EditGameWindow.cs index 737b13728..6103129c1 100644 --- a/Source/Editor/Windows/EditGameWindow.cs +++ b/Source/Editor/Windows/EditGameWindow.cs @@ -150,8 +150,22 @@ namespace FlaxEditor.Windows }; Viewport.Task.ViewFlags = ViewFlags.DefaultEditor; + Editor.SceneEditing.SelectionChanged += OnSelectionChanged; + Editor.Scene.ActorRemoved += SceneOnActorRemoved; } + + /// + public override void OnEditorStateChanged() + { + base.OnEditorStateChanged(); + UpdateCameraPreview(); + } + + private void OnSelectionChanged() + { + UpdateCameraPreview(); + } /// /// Gets a value indicating whether actor pilot feature is active and in use. @@ -376,9 +390,6 @@ namespace FlaxEditor.Windows /// public override void Update(float deltaTime) { - // TODO: call camera preview update only on selection change, or state change - UpdateCameraPreview(); - if (Root.GetKeyDown(KeyboardKeys.F12)) { Viewport.TakeScreenshot(); From 5341e355ce731e7abc74fe2792361101c4d8f92d Mon Sep 17 00:00:00 2001 From: Wojtek Figat Date: Sun, 23 Oct 2022 20:14:58 +0200 Subject: [PATCH 2/2] Code style fix #782 --- Source/Editor/Windows/EditGameWindow.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Source/Editor/Windows/EditGameWindow.cs b/Source/Editor/Windows/EditGameWindow.cs index 6103129c1..3c0d40c9d 100644 --- a/Source/Editor/Windows/EditGameWindow.cs +++ b/Source/Editor/Windows/EditGameWindow.cs @@ -151,17 +151,17 @@ namespace FlaxEditor.Windows Viewport.Task.ViewFlags = ViewFlags.DefaultEditor; Editor.SceneEditing.SelectionChanged += OnSelectionChanged; - Editor.Scene.ActorRemoved += SceneOnActorRemoved; } - + /// public override void OnEditorStateChanged() { base.OnEditorStateChanged(); + UpdateCameraPreview(); } - + private void OnSelectionChanged() { UpdateCameraPreview();