From e319b4dedc3448b966ed6131bed3289738fc9fba Mon Sep 17 00:00:00 2001 From: Wojtek Figat Date: Thu, 28 Sep 2023 19:37:08 +0200 Subject: [PATCH] Minor optimization for PhysX events cleanup --- .../Engine/Physics/PhysX/SimulationEventCallbackPhysX.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Source/Engine/Physics/PhysX/SimulationEventCallbackPhysX.cpp b/Source/Engine/Physics/PhysX/SimulationEventCallbackPhysX.cpp index 4878750eb..42f9b7a59 100644 --- a/Source/Engine/Physics/PhysX/SimulationEventCallbackPhysX.cpp +++ b/Source/Engine/Physics/PhysX/SimulationEventCallbackPhysX.cpp @@ -15,9 +15,11 @@ namespace { if (collection.IsEmpty()) return; + const auto c = collection.Get(); for (int32 i = 0; i < collection.Count(); i++) { - if (collection[i].First == collider || collection[i].Second == collider) + const SimulationEventCallback::CollidersPair cc = c[i]; + if (cc.First == collider || cc.Second == collider) { collection.RemoveAt(i--); if (collection.IsEmpty()) @@ -32,7 +34,8 @@ namespace return; for (auto i = collection.Begin(); i.IsNotEnd(); ++i) { - if (i->Key.First == collider || i->Key.Second == collider) + const SimulationEventCallback::CollidersPair cc = i->Key; + if (cc.First == collider || cc.Second == collider) { collection.Remove(i); if (collection.IsEmpty())