GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Add helper parent actor of missing object logging to HandleObjectDeserializationError

Browse Source
This commit is contained in:
Wojtek Figat
2021-08-09 12:12:56 +02:00
parent f68321c9f5
commit fd01d37002
2 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Source/Engine/Level/Level.cpp
View File

@@ -998,25 +998,9 @@ bool Level::loadScene(rapidjson_flax::Value& data, int32 engineBuild, bool autoI
auto& objData = data[i]; auto& objData = data[i];
auto obj = sceneObjects->At(i); auto obj = sceneObjects->At(i);
if (obj) if (obj)
{
SceneObjectsFactory::Deserialize(obj, objData, modifier.Value); SceneObjectsFactory::Deserialize(obj, objData, modifier.Value);
}
else else
{
SceneObjectsFactory::HandleObjectDeserializationError(objData); SceneObjectsFactory::HandleObjectDeserializationError(objData);
// Try to log some useful info about missing object (eg. it's parent name for faster fixing)
const auto parentIdMember = objData.FindMember("ParentID");
if (parentIdMember != objData.MemberEnd() && parentIdMember->value.IsString())
{
Guid parentId = JsonTools::GetGuid(parentIdMember->value);
Actor* parent = Scripting::FindObject<Actor>(parentId);
if (parent)
{
LOG(Warning, "Parent actor of the missing object: {0}", parent->GetName());
}
}
}
} }
Scripting::ObjectsLookupIdMapping.Set(nullptr); Scripting::ObjectsLookupIdMapping.Set(nullptr);
} }

14
Source/Engine/Level/SceneObjectsFactory.cpp
View File

@@ -344,11 +344,23 @@ void SceneObjectsFactory::SynchronizePrefabInstances(Array<SceneObject*>& sceneO
void SceneObjectsFactory::HandleObjectDeserializationError(const ISerializable::DeserializeStream& value) void SceneObjectsFactory::HandleObjectDeserializationError(const ISerializable::DeserializeStream& value)
{ {
// Print invalid object data contents
rapidjson_flax::StringBuffer buffer; rapidjson_flax::StringBuffer buffer;
PrettyJsonWriter writer(buffer); PrettyJsonWriter writer(buffer);
value.Accept(writer.GetWriter()); value.Accept(writer.GetWriter());
LOG(Warning, "Failed to deserialize scene object from data: {0}", String(buffer.GetString())); LOG(Warning, "Failed to deserialize scene object from data: {0}", String(buffer.GetString()));
// Try to log some useful info about missing object (eg. it's parent name for faster fixing)
const auto parentIdMember = value.FindMember("ParentID");
if (parentIdMember != value.MemberEnd() && parentIdMember->value.IsString())
{
const Guid parentId = JsonTools::GetGuid(parentIdMember->value);
Actor* parent = Scripting::FindObject<Actor>(parentId);
if (parent)
{
LOG(Warning, "Parent actor of the missing object: {0}", parent->GetName());
}
}
} }
Actor* SceneObjectsFactory::CreateActor(int32 typeId, const Guid& id) Actor* SceneObjectsFactory::CreateActor(int32 typeId, const Guid& id)