GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix pasted ghost prefab objects when paste target is not defined

Browse Source 
#3945
This commit is contained in:
Wojtek Figat
2026-03-30 10:14:50 +02:00
parent 408c6d96b1
commit 243173df3c
2 changed files with 34 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
Source/Editor/Undo/Actions/PasteActorsAction.cs
View File

@@ -41,7 +41,7 @@ namespace FlaxEditor.Actions
ActionString = name;
_pasteParent = pasteParent;
_idsMapping = new Dictionary<Guid, Guid>(objectIds.Length * 4);
_idsMapping = new Dictionary<Guid, Guid>(objectIds.Length);
for (int i = 0; i < objectIds.Length; i++)
{
_idsMapping[objectIds[i]] = Guid.NewGuid();
@@ -72,13 +72,24 @@ namespace FlaxEditor.Actions
/// <summary>
/// Links the broken parent reference (missing parent). By default links the actor to the first scene.
/// </summary>
/// <param name="actor">The actor.</param>
protected virtual void LinkBrokenParentReference(Actor actor)
/// <param name="actorNode">The actor node.</param>
protected virtual void LinkBrokenParentReference(ActorNode actorNode)
{
// Link to the first scene root
if (Level.ScenesCount == 0)
throw new Exception("Failed to paste actor with a broken reference. No loaded scenes.");
actor.SetParent(Level.GetScene(0), false);
actorNode.Actor.SetParent(Level.GetScene(0), false);
}
/// <summary>
/// Checks if actor has a broken parent reference. For example, it's linked to the parent that is indie prefab editor while it should be pasted into scene.
/// </summary>
/// <param name="actorNode">The actor node.</param>
protected virtual void CheckBrokenParentReference(ActorNode actorNode)
{
// Ensure pasted object ends up on a scene
if (actorNode.Actor.Scene == null)
LinkBrokenParentReference(actorNode);
}
/// <inheritdoc />
@@ -103,16 +114,13 @@ namespace FlaxEditor.Actions
for (int i = 0; i < actors.Length; i++)
{
var actor = actors[i];
// Check if has no parent linked (broken reference eg. old parent not existing)
if (actor.Parent == null)
{
LinkBrokenParentReference(actor);
}
var node = GetNode(actor.ID);
if (node is ActorNode actorNode)
{
// Check if has no parent linked (broken reference eg. old parent not existing)
if (actor.Parent == null)
LinkBrokenParentReference(actorNode);
nodes.Add(actorNode);
}
}
@@ -136,6 +144,12 @@ namespace FlaxEditor.Actions
nodeParents[i].Actor.SetParent(pasteParentNode.Actor, false);
}
}
else
{
// Sanity check on pasted actor to ensure they end up i na proper context (scene editor or specific prefab editor)
foreach (var node in nodeParents)
CheckBrokenParentReference(node);
}
// Store previously looked up names and the results
Dictionary<string, bool> foundNamesResults = new();

11
Source/Editor/Windows/Assets/PrefabWindow.Actions.cs
View File

@@ -264,10 +264,17 @@ namespace FlaxEditor.Windows.Assets
}
/// <inheritdoc />
protected override void LinkBrokenParentReference(Actor actor)
protected override void LinkBrokenParentReference(ActorNode actorNode)
{
// Link to prefab root
actor.SetParent(_window.Graph.MainActor, false);
actorNode.Actor.SetParent(_window.Graph.MainActor, false);
}
/// <inheritdoc />
protected override void CheckBrokenParentReference(ActorNode actorNode)
{
if (actorNode.Actor.Scene != null || actorNode.Root != _window.Graph.Root)
LinkBrokenParentReference(actorNode);
}
/// <inheritdoc />