GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize Anim Graph state machine transition rule evaluation to happen before state evaluation for early rejection

Browse Source
This commit is contained in:
Wojciech Figat
2021-12-03 15:37:33 +01:00
parent faaddccee4
commit 583b39fe6b
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
Source/Engine/Animations/Graph/AnimGroup.Animation.cpp
View File

@@ -1437,10 +1437,21 @@ void AnimGraphExecutor::ProcessGroupAnimation(Box* boxBase, Node* nodeBase, Valu
while (stateData.Transitions[transitionIndex] != AnimGraphNode::StateData::InvalidTransitionIndex
&& transitionIndex < ANIM_GRAPH_MAX_STATE_TRANSITIONS)
{
const auto idx = stateData.Transitions[transitionIndex];
ASSERT(idx >= 0 && idx < data.Graph->StateTransitions.Count());
const uint16 idx = stateData.Transitions[transitionIndex];
ASSERT(idx < data.Graph->StateTransitions.Count());
auto& transition = data.Graph->StateTransitions[idx];
const bool useDefaultRule = static_cast<int32>(transition.Flags & AnimGraphStateTransition::FlagTypes::UseDefaultRule) != 0;
const bool useDefaultRule = (transition.Flags & AnimGraphStateTransition::FlagTypes::UseDefaultRule) != 0;
if (transition.RuleGraph && !useDefaultRule)
{
// Execute transition rule
auto rootNode = transition.RuleGraph->GetRootNode();
ASSERT(rootNode);
if (!(bool)eatBox((Node*)rootNode, &rootNode->Boxes[0]))
{
transitionIndex++;
continue;
}
}
// Evaluate source state transition data (position, length, etc.)
const Value sourceStatePtr = SampleState(bucket.CurrentState);
@@ -1470,13 +1481,7 @@ void AnimGraphExecutor::ProcessGroupAnimation(Box* boxBase, Node* nodeBase, Valu
canEnter = transitionData.Position >= endPos;
}
else if (transition.RuleGraph)
{
ASSERT(transition.RuleGraph->GetRootNode());
// Execute transition rule
auto rootNode = transition.RuleGraph->GetRootNode();
canEnter = (bool)eatBox((Node*)rootNode, &rootNode->Boxes[0]);
}
canEnter = true;
if (canEnter)
{
// Start transition
@@ -1487,7 +1492,7 @@ void AnimGraphExecutor::ProcessGroupAnimation(Box* boxBase, Node* nodeBase, Valu
// Skip after Solo transition
// TODO: don't load transitions after first enabled Solo transition and remove this check here
if (static_cast<int32>(transition.Flags & AnimGraphStateTransition::FlagTypes::Solo) != 0)
if ((transition.Flags & AnimGraphStateTransition::FlagTypes::Solo) != 0)
break;
transitionIndex++;