GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Fix unnecessary allocations when creating managed arrays

Browse Source
This commit is contained in:
Ari Vuollet
2022-12-22 18:12:33 +02:00
parent 22b4e25c02
commit 6a41ab0b6d
1 changed files with 23 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
Source/Engine/Engine/NativeInterop.cs
View File

@@ -1864,18 +1864,14 @@ namespace FlaxEngine
internal static class ArrayFactory
{
private static class Internal<T>
{
internal static Array CreateArrayDelegate(long size) => new T[size];
}
private delegate Array CreateArrayDelegate(long size);
private static ConcurrentDictionary<Type, Type> marshalledTypes = new ConcurrentDictionary<Type, Type>(1, 3);
private static ConcurrentDictionary<Type, CreateArrayDelegate> createArrayDelegates = new ConcurrentDictionary<Type, CreateArrayDelegate>(1, 3);
private static CreateArrayDelegate GetCreateArrayDelegate(Type type)
internal static Type GetMarshalledType(Type elementType)
{
static CreateArrayDelegate Factory(Type type)
static Type Factory(Type type)
{
Type marshalType;
if (IsBlittable(type))
@@ -1883,18 +1879,33 @@ namespace FlaxEngine
else
marshalType = GetInternalType(type) ?? typeof(IntPtr);
MethodInfo method = typeof(Internal<>).MakeGenericType(marshalType).GetMethod(nameof(Internal<ValueTypePlaceholder>.CreateArrayDelegate), BindingFlags.Static | BindingFlags.NonPublic);
return marshalType;
}
if (marshalledTypes.TryGetValue(elementType, out var marshalledType))
return marshalledType;
return marshalledTypes.GetOrAdd(elementType, Factory);
}
internal static Array CreateArray(Type type, long size)
{
static CreateArrayDelegate Factory(Type type)
{
Type marshalledType = GetMarshalledType(type);
MethodInfo method = typeof(Internal<>).MakeGenericType(marshalledType).GetMethod(nameof(Internal<ValueTypePlaceholder>.CreateArrayDelegate), BindingFlags.Static | BindingFlags.NonPublic);
return method.CreateDelegate<CreateArrayDelegate>();
}
if (createArrayDelegates.TryGetValue(type, out var deleg))
return deleg;
return createArrayDelegates.GetOrAdd(type, Factory);
return deleg(size);
return createArrayDelegates.GetOrAdd(type, Factory)(size);
}
internal static Array CreateArray(Type type, long size) => GetCreateArrayDelegate(type)(size);
internal static Type GetMarshalledType(Type elementType) => GetCreateArrayDelegate(elementType).Method.DeclaringType.GenericTypeArguments[0];
private static class Internal<T>
{
internal static Array CreateArrayDelegate(long size) => new T[size];
}
}
[UnmanagedCallersOnly]