GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Improve Write/ReadString implementation and comments

Browse Source
This commit is contained in:
Damian Korczowski
2021-06-27 12:25:45 +02:00
parent a6ccbe3876
commit 95c86efd31
2 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
Source/Engine/Networking/NetworkMessage.cs
View File

@@ -246,7 +246,7 @@ namespace FlaxEngine.Networking
}
/// <summary>
/// Writes data of type <see cref="string"/> into the message. UTF-8 encoded.
/// Writes data of type <see cref="string"/> into the message. UTF-16 encoded.
/// </summary>
public void WriteString(string value)
{
@@ -254,23 +254,21 @@ namespace FlaxEngine.Networking
var data = Encoding.Unicode.GetBytes(value);
WriteUInt16((ushort)data.Length); // TODO: Use 1-byte length when possible
WriteBytes(data, data.Length);
WriteBytes(data, data.Length * sizeof(ushort));
}
/// <summary>
/// Reads and returns data of type <see cref="string"/> from the message. UTF-8 encoded.
/// Reads and returns data of type <see cref="string"/> from the message. UTF-16 encoded.
/// </summary>
public string ReadString()
{
// Note: Make sure that this is consistent with the C++ message API!
var stringLength = ReadUInt16();
var bytes = new byte[stringLength];
fixed (byte* bytesPtr = bytes)
{
ReadBytes(bytesPtr, stringLength);
}
return Encoding.Unicode.GetString(bytes);
var stringLength = ReadUInt16(); // In chars
var stringSize = stringLength * sizeof(ushort); // In bytes
var bytes = stackalloc char[stringSize];
ReadBytes((byte*)bytes, stringSize);
return new string(bytes);
}
/// <summary>