GoaLitiuM/FlaxEngine
1
0
Fork 0
Code Issues Pull Requests Actions 7 Packages Projects Releases Wiki Activity

Optimize MMethod::GetParameterIsOut to cache all parameters in a single bit-flag

Browse Source
This commit is contained in:
Wojtek Figat
2026-03-30 19:56:32 +02:00
parent 2748216190
commit d96e1297f7
3 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Engine/Engine/NativeInterop.Unmanaged.cs
View File

@@ -1197,11 +1197,17 @@ namespace FlaxEngine.Interop
}
[UnmanagedCallersOnly]
internal static byte GetMethodParameterIsOut(ManagedHandle methodHandle, int parameterNum)
internal static UInt64 GetMethodParameterIsOut(ManagedHandle methodHandle)
{
MethodHolder methodHolder = Unsafe.As<MethodHolder>(methodHandle.Target);
ParameterInfo parameterInfo = methodHolder.method.GetParameters()[parameterNum];
return (byte)(parameterInfo.IsOut ? 1 : 0);
var parameters = methodHolder.method.GetParameters();
UInt64 result = 0;
for (int i = 0; i < parameters.Length; i++)
{
if (parameters[i].IsOut)
result |= 1ul << i;
}
return result;
}
[UnmanagedCallersOnly]

1
Source/Engine/Scripting/ManagedCLR/MMethod.h
View File

@@ -29,6 +29,7 @@ protected:
int32 _paramsCount;
mutable void* _returnType;
mutable Array<void*, InlinedAllocation<8>> _parameterTypes;
mutable uint64 _parameterOuts = 0;
void CacheSignature() const;
#else
StringAnsiView _name;

7
Source/Engine/Scripting/Runtime/DotNet.cpp
View File

@@ -1514,13 +1514,16 @@ void MMethod::CacheSignature() const
static void* GetMethodReturnTypePtr = GetStaticMethodPointer(TEXT("GetMethodReturnType"));
static void* GetMethodParameterTypesPtr = GetStaticMethodPointer(TEXT("GetMethodParameterTypes"));
static void* GetMethodParameterIsOutPtr = GetStaticMethodPointer(TEXT("GetMethodParameterIsOut"));
_returnType = CallStaticMethod<void*, void*>(GetMethodReturnTypePtr, _handle);
_parameterOuts = 0;
if (_paramsCount != 0)
{
void** parameterTypeHandles;
CallStaticMethod<void, void*, void***>(GetMethodParameterTypesPtr, _handle, &parameterTypeHandles);
_parameterTypes.Set(parameterTypeHandles, _paramsCount);
MCore::GC::FreeMemory(parameterTypeHandles);
_parameterOuts = CallStaticMethod<uint64, void*>(GetMethodParameterIsOutPtr, _handle);
}
_hasCachedSignature = true;
@@ -1587,9 +1590,7 @@ bool MMethod::GetParameterIsOut(int32 paramIdx) const
if (!_hasCachedSignature)
CacheSignature();
ASSERT_LOW_LAYER(paramIdx >= 0 && paramIdx < _paramsCount);
// TODO: cache GetParameterIsOut maybe?
static void* GetMethodParameterIsOutPtr = GetStaticMethodPointer(TEXT("GetMethodParameterIsOut"));
return CallStaticMethod<bool, void*, int>(GetMethodParameterIsOutPtr, _handle, paramIdx);
return _parameterOuts & (1ull << paramIdx);
}
bool MMethod::HasAttribute(const MClass* klass) const