Optimize text formatting in various places

This commit is contained in:
Wojtek Figat
2023-05-09 13:44:32 +02:00
parent 2cf70453f8
commit d13c722ce3
5 changed files with 14 additions and 13 deletions

View File

@@ -191,7 +191,7 @@ void EditorAnalytics::EndSession()
// End session // End session
{ {
StringAnsi sessionLength = StringAnsi::Format("{0}", (int32)(DateTime::Now() - SessionStartTime).GetTotalSeconds()); StringAnsi sessionLength = StringAnsi::Format("{}", (int32)(DateTime::Now() - SessionStartTime).GetTotalSeconds());
const Pair<const char*, const char*> params[1] = const Pair<const char*, const char*> params[1] =
{ {
{ "Duration", sessionLength.Get() }, { "Duration", sessionLength.Get() },

View File

@@ -329,10 +329,10 @@ bool GPUDeviceDX12::Init()
// Spawn some info about the hardware // Spawn some info about the hardware
D3D12_FEATURE_DATA_D3D12_OPTIONS options; D3D12_FEATURE_DATA_D3D12_OPTIONS options;
VALIDATE_DIRECTX_RESULT(_device->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS, &options, sizeof(options))); VALIDATE_DIRECTX_RESULT(_device->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS, &options, sizeof(options)));
LOG(Info, "Tiled Resources Tier: {0}", options.TiledResourcesTier); LOG(Info, "Tiled Resources Tier: {0}", (int32)options.TiledResourcesTier);
LOG(Info, "Resource Binding Tier: {0}", options.ResourceBindingTier); LOG(Info, "Resource Binding Tier: {0}", (int32)options.ResourceBindingTier);
LOG(Info, "Conservative Rasterization Tier: {0}", options.ConservativeRasterizationTier); LOG(Info, "Conservative Rasterization Tier: {0}", (int32)options.ConservativeRasterizationTier);
LOG(Info, "Resource Heap Tier: {0}", options.ResourceHeapTier); LOG(Info, "Resource Heap Tier: {0}", (int32)options.ResourceHeapTier);
// Init device limits // Init device limits
{ {

View File

@@ -1899,13 +1899,14 @@ bool GPUDeviceVulkan::Init()
{ {
dataPtr++; dataPtr++;
const int32 version = *dataPtr++; const int32 version = *dataPtr++;
if (version == VK_PIPELINE_CACHE_HEADER_VERSION_ONE) const int32 versionExpected = VK_PIPELINE_CACHE_HEADER_VERSION_ONE;
if (version == versionExpected)
{ {
dataPtr += VK_UUID_SIZE / sizeof(int32); dataPtr += VK_UUID_SIZE / sizeof(int32);
} }
else else
{ {
LOG(Warning, "Bad validation cache file, version: {0}, expected: {1}", version, VK_PIPELINE_CACHE_HEADER_VERSION_ONE); LOG(Warning, "Bad validation cache file, version: {0}, expected: {1}", version, versionExpected);
data.Clear(); data.Clear();
} }
} }

View File

@@ -600,7 +600,7 @@ bool CollisionCooking::CookConvexMesh(CookingInput& input, BytesContainer& outpu
PxConvexMeshCookingResult::Enum result; PxConvexMeshCookingResult::Enum result;
if (!cooking->cookConvexMesh(desc, outputStream, &result)) if (!cooking->cookConvexMesh(desc, outputStream, &result))
{ {
LOG(Warning, "Convex Mesh cooking failed. Error code: {0}, Input vertices count: {1}", result, input.VertexCount); LOG(Warning, "Convex Mesh cooking failed. Error code: {0}, Input vertices count: {1}", (int32)result, input.VertexCount);
return true; return true;
} }
@@ -634,7 +634,7 @@ bool CollisionCooking::CookTriangleMesh(CookingInput& input, BytesContainer& out
PxTriangleMeshCookingResult::Enum result; PxTriangleMeshCookingResult::Enum result;
if (!cooking->cookTriangleMesh(desc, outputStream, &result)) if (!cooking->cookTriangleMesh(desc, outputStream, &result))
{ {
LOG(Warning, "Triangle Mesh cooking failed. Error code: {0}, Input vertices count: {1}, indices count: {2}", result, input.VertexCount, input.IndexCount); LOG(Warning, "Triangle Mesh cooking failed. Error code: {0}, Input vertices count: {1}, indices count: {2}", (int32)result, input.VertexCount, input.IndexCount);
return true; return true;
} }

View File

@@ -40,11 +40,11 @@ ShaderGraphValue::ShaderGraphValue(const Variant& v)
break; break;
case VariantType::Float: case VariantType::Float:
Type = VariantType::Types::Float; Type = VariantType::Types::Float;
Value = String::Format(TEXT("{0}"), v.AsFloat); Value = String::Format(TEXT("{}"), v.AsFloat);
break; break;
case VariantType::Double: case VariantType::Double:
Type = VariantType::Types::Float; Type = VariantType::Types::Float;
Value = String::Format(TEXT("{0}"), (float)v.AsDouble); Value = String::Format(TEXT("{}"), (float)v.AsDouble);
break; break;
case VariantType::Float2: case VariantType::Float2:
{ {
@@ -412,7 +412,7 @@ ShaderGraphValue ShaderGraphValue::Cast(const ShaderGraphValue& v, VariantType::
case VariantType::Types::Float4: case VariantType::Types::Float4:
case VariantType::Types::Double4: case VariantType::Types::Double4:
case VariantType::Types::Quaternion: case VariantType::Types::Quaternion:
format = TEXT("{0}"); format = TEXT("{}");
break; break;
} }
break; break;
@@ -422,7 +422,7 @@ ShaderGraphValue ShaderGraphValue::Cast(const ShaderGraphValue& v, VariantType::
case VariantType::Types::Color: case VariantType::Types::Color:
case VariantType::Types::Float4: case VariantType::Types::Float4:
case VariantType::Types::Double4: case VariantType::Types::Double4:
format = TEXT("{0}"); format = TEXT("{}");
break; break;
} }
break; break;